[PATCH] D157015: [llvm][Support] Avoid heap allocations in `StringSaver`

[Jan Svoboda via Phabricator via llvm-commits]

jansvoboda11 created this revision.
jansvoboda11 added reviewers: dblaikie, benlangmuir.
Herald added subscribers: ributzka, hiraditya.
Herald added a project: All.
jansvoboda11 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The `Twine::str()` function currently always allocates heap memory via `std::string`. However, some instances of `Twine` don't need an intermediate buffer at all, and the rest can attempt to print into a stack buffer first.

This is intentionally not making use of `Twine::isSingleStringLiteral()` from D157010 <https://reviews.llvm.org/D157010> to skip saving the string in the bump-pointer allocator, since the documentation suggests that MUST happen for every given string.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D157015

Files:
  llvm/include/llvm/Support/StringSaver.h
  llvm/lib/Support/StringSaver.cpp


Index: llvm/lib/Support/StringSaver.cpp
===================================================================
--- llvm/lib/Support/StringSaver.cpp
+++ llvm/lib/Support/StringSaver.cpp
@@ -8,6 +8,8 @@
 
 #include "llvm/Support/StringSaver.h"
 
+#include "llvm/ADT/SmallString.h"
+
 using namespace llvm;
 
 StringRef StringSaver::save(StringRef S) {
@@ -18,9 +20,19 @@
   return StringRef(P, S.size());
 }
 
+StringRef StringSaver::save(const Twine &S) {
+  SmallString<128> Storage;
+  return save(S.toStringRef(Storage));
+}
+
 StringRef UniqueStringSaver::save(StringRef S) {
   auto R = Unique.insert(S);
   if (R.second)                 // cache miss, need to actually save the string
     *R.first = Strings.save(S); // safe replacement with equal value
   return *R.first;
 }
+
+StringRef UniqueStringSaver::save(const Twine &S) {
+  SmallString<128> Storage;
+  return save(S.toStringRef(Storage));
+}
Index: llvm/include/llvm/Support/StringSaver.h
===================================================================
--- llvm/include/llvm/Support/StringSaver.h
+++ llvm/include/llvm/Support/StringSaver.h
@@ -29,7 +29,7 @@
   // All returned strings are null-terminated: *save(S).end() == 0.
   StringRef save(const char *S) { return save(StringRef(S)); }
   StringRef save(StringRef S);
-  StringRef save(const Twine &S) { return save(StringRef(S.str())); }
+  StringRef save(const Twine &S);
   StringRef save(const std::string &S) { return save(StringRef(S)); }
 };
 
@@ -51,7 +51,7 @@
   // All returned strings are null-terminated: *save(S).end() == 0.
   StringRef save(const char *S) { return save(StringRef(S)); }
   StringRef save(StringRef S);
-  StringRef save(const Twine &S) { return save(StringRef(S.str())); }
+  StringRef save(const Twine &S);
   StringRef save(const std::string &S) { return save(StringRef(S)); }
 };
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157015.546931.patch
Type: text/x-patch
Size: 1842 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230803/afaab0a4/attachment.bin>