[PATCH] D156926: [RISCV] Add bf16 to isFPImmLegal.

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

LGTM as well



================
Comment at: llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:848
         llvm_unreachable("Unexpected size");
       case MVT::f16:
         Opc = RISCV::FLI_H;
----------------
craig.topper wrote:
> reames wrote:
> > Don't you need handling for bf16 here?
> I think getLegalZfaFPImm should return -1 for bf16 since we don't have a bf16 FLI instruction.
Yep, I'd misread the code. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156926/new/

https://reviews.llvm.org/D156926