[PATCH] D156968: [ARM] v6-M XO: save CPSR around LoadStackGuard

Thu Aug 3 03:22:59 PDT 2023

stuij added a comment.

As a general FYI, when uploading a patch, please keep the whole context of the file, so people can move up and down the file in Phab, instead of being presented with `Context not available.`. I'm not sure what your process is of creating a review (I use Arc myself), but it'd be something like:
`git format-patch -k -U999999 @{u}`.

================
Comment at: llvm/test/CodeGen/Thumb/stack-guard-xo-sub64.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 3
+; RUN: llc < %s -mtriple=thumbv6m -mattr=+execute-only | FileCheck %s -check-prefix=V6M
----------------
I would put this test in `stack-guard-xo.ll`. One test per file seems a bit too granular to me.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156968/new/

https://reviews.llvm.org/D156968