[PATCH] D151414: [RISCV] Add Zvfhmin extension support for llvm RISCV backend.

[Jianjian Guan via Phabricator via llvm-commits]

jacquesguan added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:900
+        setOperationAction({ISD::VP_FP_ROUND, ISD::VP_FP_EXTEND}, VT, Custom);
+        // TODO: make others promote?
+      }
----------------
michaelmaitland wrote:
> What is the reason not to use `SetCommonVFPActions` and `SetCommonVFPExtLoadTruncStoreActions`? I think we should be able to do all of these common VFP actions if we promote to f32 first.
Here is my patch for promoting f16 vector op zvfhmin https://reviews.llvm.org/D153848. As you say we can do all of these common VFP actions if we promote to f32 first, but then we have a f32 vector op and the action of it should be set under the f32 vector op scope which already used `SetCommonVFPActions` and `SetCommonVFPExtLoadTruncStoreActions`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151414/new/

https://reviews.llvm.org/D151414