[PATCH] D151414: [RISCV] Add Zvfhmin extension support for llvm RISCV backend.

Michael Maitland via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 1 16:15:17 PDT 2023


michaelmaitland added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:900
+        setOperationAction({ISD::VP_FP_ROUND, ISD::VP_FP_EXTEND}, VT, Custom);
+        // TODO: make others promote?
+      }
----------------
What is the reason not to use `SetCommonVFPActions` and `SetCommonVFPExtLoadTruncStoreActions`? I think we should be able to do all of these common VFP actions if we promote to f32 first.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151414/new/

https://reviews.llvm.org/D151414



More information about the llvm-commits mailing list