[PATCH] D156499: [InstCombine] Fold abs of known sign operand when source is sub

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added a comment.

In D156499#4549679 <https://reviews.llvm.org/D156499#4549679>, @Allen wrote:

>>> Thanks for your attention, I already put the each alive2 link before the matched cases, so do you mean I also should put that in the MR description ?
>>
>> Bah sorry for not following up on this, but where are the alive2 links?
>
> hi @goldstein.w.n，I usually add the alive2 links before the matched cases because there is more than 1 case, such as line 455 in file Transforms/InstCombine/abs-intrinsic.ll  (it is more obvious on D156521 <https://reviews.llvm.org/D156521>)
> do you mean it is better to put that  in the MR description, too ?

MR?

I mean the commit message of this patch (and summary in phab if the two should ever desync).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156499/new/

https://reviews.llvm.org/D156499