[PATCH] D156499: [InstCombine] Fold abs of known sign operand when source is sub
Allen zhong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 1 01:19:15 PDT 2023
Allen added a comment.
>> Thanks for your attention, I already put the each alive2 link before the matched cases, so do you mean I also should put that in the MR description ?
>
> Bah sorry for not following up on this, but where are the alive2 links?
hi @goldstein.w.n,I usually add the alive2 links before the matched cases because there is more than 1 case, such as line 455 in file Transforms/InstCombine/abs-intrinsic.ll (it is more obvious on D156521 <https://reviews.llvm.org/D156521>)
do you mean it is better to put that in the MR description, too ?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156499/new/
https://reviews.llvm.org/D156499
More information about the llvm-commits
mailing list