[PATCH] D156742: [BOLT][DWARF] Fix handling inlined subroutine with no output pc.

[Alexander Yermolovich via Phabricator via llvm-commits]

ayermolo added inline comments.


================
Comment at: bolt/lib/Rewrite/DWARFRewriter.cpp:868
         consumeError(RangesOrError.takeError());
+      } else if (OutputRanges.empty()) {
+        if (RangesOrError.get().front().LowPC)
----------------
maksfb wrote:
> ayermolo wrote:
> > maksfb wrote:
> > > maksfb wrote:
> > > > The condition is always `true` here.
> > > Remove unnecessary check.
> > Removed, but it proved useful. Added extra test that would trigger it.
> Sorry, I don't follow. What was useful? I was talking about the check for `OutputRanges.empty()`.
oh, I thought you were referring to the low_pc check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156742/new/

https://reviews.llvm.org/D156742