[PATCH] D156742: [BOLT][DWARF] Fix handling inlined subroutine with no output pc.

[Maksim Panchenko via Phabricator via llvm-commits]

maksfb added inline comments.


================
Comment at: bolt/lib/Rewrite/DWARFRewriter.cpp:868
         consumeError(RangesOrError.takeError());
+      } else if (OutputRanges.empty()) {
+        if (RangesOrError.get().front().LowPC)
----------------
ayermolo wrote:
> maksfb wrote:
> > maksfb wrote:
> > > The condition is always `true` here.
> > Remove unnecessary check.
> Removed, but it proved useful. Added extra test that would trigger it.
Sorry, I don't follow. What was useful? I was talking about the check for `OutputRanges.empty()`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156742/new/

https://reviews.llvm.org/D156742