[PATCH] D156685: [RISCV] Match ext_vl + ext_vl + srem + trunc_vl to vrem.vv

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 31 11:54:38 PDT 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVVLPatterns.td:2236
+  def : Pat<
+      (vti.Vector 
+        (riscv_trunc_vector_vl
----------------
LWenH wrote:
> Jim wrote:
> > indents doesn't look similar with other pat definition.
> Sure, but I'm not quite familiar with such process of pre-commit test in LLVM, could you give me some hint about the pre-commit test here or how to do so?
Make a separate phabricator review with the new test cases. Update this patch to show how those tests are changed. Add the pre-commit patch as a parent of this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156685/new/

https://reviews.llvm.org/D156685



More information about the llvm-commits mailing list