[PATCH] D156437: [RISCV] Fix the CFI offset for callee-saved registers stored by Zcmp push.

[Kito Cheng via Phabricator via llvm-commits]

kito-cheng added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:587-588
+        // Callee-saved register stored by Zcmp push is in reverse order.
+        // .cfi_offset ra, -4 => .cfi_offset ra, -8
+        // .cfi_offset s0, -8 => .cfi_offset s0, -4
+        Offset = -(FrameIdx + RVFI->getRVPushRegs() + 1) *
----------------
Drop this two line, it might cause confusion IMO.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156437/new/

https://reviews.llvm.org/D156437