[PATCH] D156136: [BPF] Clean up SelLowering

[Yonghong Song via Phabricator via llvm-commits]

yonghong-song accepted this revision.
yonghong-song added a comment.

LGTM except one minor suggestion.



================
Comment at: llvm/lib/Target/BPF/BPFISelLowering.cpp:379
+  if (MF.getFunction().hasStructRetAttr())
+    fail(DL, DAG, "sret functions are not supported");
 
----------------
User may not understand what 'sret' means without looking at source code.
Maybe 'functions with returning struct are not supported'?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156136/new/

https://reviews.llvm.org/D156136