[PATCH] D156136: [BPF] Clean up SelLowering

[Tamir Duberstein via Phabricator via llvm-commits]

tamird added inline comments.


================
Comment at: llvm/lib/Target/BPF/BPFISelLowering.cpp:379
+  if (MF.getFunction().hasStructRetAttr())
+    fail(DL, DAG, "sret functions are not supported");
 
----------------
yonghong-song wrote:
> User may not understand what 'sret' means without looking at source code.
> Maybe 'functions with returning struct are not supported'?
Thanks, I agree this error message is not very clear. I'd like to update it, but I notice that the existing tests do not cover it. Do you know how to write a function that would produce IR with the `sret` attribute?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156136/new/

https://reviews.llvm.org/D156136