[PATCH] D156136: [BPF] Clean up SelLowering

Alexei Starovoitov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 28 16:22:55 PDT 2023


ast added a comment.

In D156136#4543417 <https://reviews.llvm.org/D156136#4543417>, @eddyz87 wrote:

> I left a few minor comments.
> All-in-all I think these modifications are fine if it makes BPF backend simpler to work with.
> However, I'm not sure if fixing my comments is worthwhile if Alexei objects the whole idea.

Looks fine to me as well.
@yonghong-song please take a look too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156136/new/

https://reviews.llvm.org/D156136



More information about the llvm-commits mailing list