[PATCH] D156099: [AMDGPU] Add True16 register classes.

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec accepted this revision.
rampitec added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Target/AMDGPU/SIRegisterInfo.td:1034
+def VS_16 : SIRegisterClass<"AMDGPU", Reg16Types.types, 16,
+                          (add VGPR_16, SReg_32, LDS_DIRECT_CLASS)> {
+  let isAllocatable = 0;
----------------
kosarev wrote:
> rampitec wrote:
> > Does this really work when you have an RC with registers of different size?
> > Does this really work when you have an RC with registers of different size?
> 
> It seems so, yes. Downstream I see us generating instructions like `v_and_b16 v0.l, s2, v0.l` without problem.
OK, thanks! I used to have problems with this in the past, thus the question.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156099/new/

https://reviews.llvm.org/D156099