[PATCH] D156129: Attributor: Try to propagate concrete denormal-fp-math{-f32}

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 25 09:34:28 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:8857
+    DenormalMode ModeF32 = F->getDenormalModeF32Raw();
+    Known = Assumed = DenormalState{Mode, ModeF32};
+  }
----------------
jdoerfert wrote:
> Assumed should be more optimistic, this is a fix point, we'll never call update(Impl)
There isn't really an optimistic vs. not choice. There's only do we know or not, you can't declare one of the modes better than the other


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156129/new/

https://reviews.llvm.org/D156129



More information about the llvm-commits mailing list