[PATCH] D156129: Attributor: Try to propagate concrete denormal-fp-math{-f32}

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:1888
                            const ArrayRef<Attribute::AttrKind> &AttrKinds);
+  ChangeStatus removeAttrs(const IRPosition &IRP, ArrayRef<Attribute> Attrs);
 
----------------
Make it clear this is for string attributes, maybe even just pass the string keys.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:8857
+    DenormalMode ModeF32 = F->getDenormalModeF32Raw();
+    Known = Assumed = DenormalState{Mode, ModeF32};
+  }
----------------
Assumed should be more optimistic, this is a fix point, we'll never call update(Impl)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156129/new/

https://reviews.llvm.org/D156129