[PATCH] D156129: Attributor: Try to propagate concrete denormal-fp-math{-f32}

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:8857
+    DenormalMode ModeF32 = F->getDenormalModeF32Raw();
+    Known = Assumed = DenormalState{Mode, ModeF32};
+  }
----------------
arsenm wrote:
> jdoerfert wrote:
> > Assumed should be more optimistic, this is a fix point, we'll never call update(Impl)
> There isn't really an optimistic vs. not choice. There's only do we know or not, you can't declare one of the modes better than the other
The isFixpoint is more sophisticated than known == assumed


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156129/new/

https://reviews.llvm.org/D156129