[PATCH] D149248: [RISCV][MC] MC layer support for the experimental zacas extension

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:3338
+    unsigned Rs2 = Inst.getOperand(2).getReg();
+    if (Rd % 2 == 1) {
+      SMLoc Loc = Operands[1]->getStartLoc();
----------------
Very minor, but != 0 would read more naturally for me here.  Checking for odd, and then an error message about even requires one extra second of thought.

Same with the one below.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149248/new/

https://reviews.llvm.org/D149248