[PATCH] D154309: [LV] Do not add load to group if it moves across conflicting store.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Analysis/VectorUtils.cpp:1147
+        // Skip B if no new instructions can be added to its load group.
+        if (CompletedLoadGroups.contains(Group))
+          continue;
----------------
anna wrote:
> Can we move this above the insertion to LoadGroups since this `Group` should already be present in LoadGroups? 
> ```
> // Skip B if no new instructions can be added to its load group.
>  if (CompletedLoadGroups.contains(Group))
>       continue;
> LoadGroups.insert(Group)
> ```
> 
Thanks, adjusted in the committed version.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154309/new/

https://reviews.llvm.org/D154309