[PATCH] D154309: [LV] Do not add load to group if it moves across conflicting store.

[Anna Thomas via Phabricator via llvm-commits]

anna accepted this revision.
anna added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: wangpc.

LGTM with comment. Thanks!



================
Comment at: llvm/lib/Analysis/VectorUtils.cpp:1147
+        // Skip B if no new instructions can be added to its load group.
+        if (CompletedLoadGroups.contains(Group))
+          continue;
----------------
Can we move this above the insertion to LoadGroups since this `Group` should already be present in LoadGroups? 
```
// Skip B if no new instructions can be added to its load group.
 if (CompletedLoadGroups.contains(Group))
      continue;
LoadGroups.insert(Group)
```



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154309/new/

https://reviews.llvm.org/D154309