[PATCH] D152921: [lld] Synthesize metadata for MTE globals

[Mitch Phillips via Phabricator via llvm-commits]

hctim marked 5 inline comments as done.
hctim added inline comments.


================
Comment at: lld/test/ELF/aarch64-memtag-globals.s:16
+# RUN: llvm-objdump -Dz %t.so | FileCheck %s --check-prefix=CHECK-SPECIAL-RELOCS
+
+# CHECK: Symbol table '.dynsym' contains
----------------
peter.smith wrote:
> Worth dumping the dynamic tags to check for DT_AARCH64_MEMTAG_GLOBALS and DT_AARCH64_MEMTAG_GLOBALSSZ ?
> 
> Also could be worth dumping section headers to check for SHT_AARCH64_MEMTAG_GLOBALS_DYNAMIC
The dynamic entries are dumped by `--memtag` (see the checks near "CHECK: Memtag Dynamic Entries").

For `SHT_AARCH64_MEMTAG_GLOBALS_DYNAMIC`, done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152921/new/

https://reviews.llvm.org/D152921