[PATCH] D154665: caught bug in ElfObjectFile.h

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 6 20:19:18 PDT 2023


MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/ELF/section-no-symbol-name.test:4
+
+# CHECK: invalid section index:
+
----------------
If there is a warning or error, we usually include `warning:` or `error:`. See other tests.


================
Comment at: llvm/test/tools/llvm-objdump/ELF/section-no-symbol-name.test:17
+  - Name:         ""
+    Index:        0x43
+    Type:         STT_SECTION
----------------
Add a comment `## Invalid section index`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154665/new/

https://reviews.llvm.org/D154665



More information about the llvm-commits mailing list