[PATCH] D154665: caught bug in ElfObjectFile.h

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 6 19:20:13 PDT 2023


mtrofin added a comment.

you probably want to change the commit title to something more specific - e.g. "fix  invalid section handling in `ELFObjectFile::getSymbolName`" and capture in the description what happens - i.e. without the fix, the test in this patch segfaults (iirc)



================
Comment at: llvm/test/tools/llvm-objdump/ELF/section-no-symbol-name.test:19
+    Type:         STT_SECTION
\ No newline at end of file

----------------
newline


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154665/new/

https://reviews.llvm.org/D154665



More information about the llvm-commits mailing list