[PATCH] D153788: [SystemZ][z/OS] z/OS ADA codegen and emission

Yusra Syeda via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 6 07:20:47 PDT 2023


yusra.syeda added inline comments.


================
Comment at: llvm/lib/Target/SystemZ/SystemZAsmPrinter.cpp:971
+    unsigned Offset = Entry.second;
+    assert(Offset == EmittedBytes && "Offset not as expected");
+#define EMIT_COMMENT(Str)                                                      \
----------------
uweigand wrote:
> chapuni wrote:
> > `EmittedBytes` is unused in -Asserts.
> Right, looks like this needs a `(void)EmittedBytes;` after the assert.  @yusra.syeda can you add this?
Sure, I can add this. Can I commit this directly or create a review for it first?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153788/new/

https://reviews.llvm.org/D153788



More information about the llvm-commits mailing list