[PATCH] D153788: [SystemZ][z/OS] z/OS ADA codegen and emission

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 6 06:58:20 PDT 2023


uweigand added inline comments.


================
Comment at: llvm/lib/Target/SystemZ/SystemZAsmPrinter.cpp:971
+    unsigned Offset = Entry.second;
+    assert(Offset == EmittedBytes && "Offset not as expected");
+#define EMIT_COMMENT(Str)                                                      \
----------------
chapuni wrote:
> `EmittedBytes` is unused in -Asserts.
Right, looks like this needs a `(void)EmittedBytes;` after the assert.  @yusra.syeda can you add this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153788/new/

https://reviews.llvm.org/D153788



More information about the llvm-commits mailing list