[llvm] 62748e9 - AMDGPU: Remove add_dependencies calls from CMakeLists.txt

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 5 20:03:28 PDT 2023


Author: Tom Stellard
Date: 2023-07-05T20:03:11-07:00
New Revision: 62748e934c74550843f741f7cd194da2f604ce13

URL: https://github.com/llvm/llvm-project/commit/62748e934c74550843f741f7cd194da2f604ce13
DIFF: https://github.com/llvm/llvm-project/commit/62748e934c74550843f741f7cd194da2f604ce13.diff

LOG: AMDGPU: Remove add_dependencies calls from CMakeLists.txt

These are redundant.  The same dependencies are being added as part
of the add_llvm_component_library() call.  I confirmed this by diff'ing
the build.ninja files before and after the change and saw no change.

Reviewed By: arsenm

Differential Revision: https://reviews.llvm.org/D153166

Added: 
    

Modified: 
    llvm/lib/Target/AMDGPU/AsmParser/CMakeLists.txt
    llvm/lib/Target/AMDGPU/Disassembler/CMakeLists.txt
    llvm/lib/Target/AMDGPU/MCA/CMakeLists.txt
    llvm/lib/Target/AMDGPU/MCTargetDesc/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AMDGPU/AsmParser/CMakeLists.txt b/llvm/lib/Target/AMDGPU/AsmParser/CMakeLists.txt
index 756a8e9f8f692d..1947f5bc828639 100644
--- a/llvm/lib/Target/AMDGPU/AsmParser/CMakeLists.txt
+++ b/llvm/lib/Target/AMDGPU/AsmParser/CMakeLists.txt
@@ -14,5 +14,3 @@ add_llvm_component_library(LLVMAMDGPUAsmParser
   ADD_TO_COMPONENT
   AMDGPU
   )
-
-add_dependencies(LLVMAMDGPUAsmParser LLVMAMDGPUUtils)

diff  --git a/llvm/lib/Target/AMDGPU/Disassembler/CMakeLists.txt b/llvm/lib/Target/AMDGPU/Disassembler/CMakeLists.txt
index 012f9e754d16b2..aa96d67c527a48 100644
--- a/llvm/lib/Target/AMDGPU/Disassembler/CMakeLists.txt
+++ b/llvm/lib/Target/AMDGPU/Disassembler/CMakeLists.txt
@@ -15,5 +15,3 @@ add_llvm_component_library(LLVMAMDGPUDisassembler
   ADD_TO_COMPONENT
   AMDGPU
   )
-
-add_dependencies(LLVMAMDGPUDisassembler AMDGPUCommonTableGen LLVMAMDGPUUtils)

diff  --git a/llvm/lib/Target/AMDGPU/MCA/CMakeLists.txt b/llvm/lib/Target/AMDGPU/MCA/CMakeLists.txt
index f640392ca42a01..79db732d55bb1f 100644
--- a/llvm/lib/Target/AMDGPU/MCA/CMakeLists.txt
+++ b/llvm/lib/Target/AMDGPU/MCA/CMakeLists.txt
@@ -15,5 +15,3 @@ add_llvm_component_library(LLVMAMDGPUTargetMCA
   ADD_TO_COMPONENT
   AMDGPU
   )
-
-add_dependencies(LLVMAMDGPUTargetMCA LLVMAMDGPUUtils)

diff  --git a/llvm/lib/Target/AMDGPU/MCTargetDesc/CMakeLists.txt b/llvm/lib/Target/AMDGPU/MCTargetDesc/CMakeLists.txt
index bd7755a6a852bb..5dc76071b0594e 100644
--- a/llvm/lib/Target/AMDGPU/MCTargetDesc/CMakeLists.txt
+++ b/llvm/lib/Target/AMDGPU/MCTargetDesc/CMakeLists.txt
@@ -24,5 +24,3 @@ add_llvm_component_library(LLVMAMDGPUDesc
   ADD_TO_COMPONENT
   AMDGPU
   )
-
-add_dependencies(LLVMAMDGPUDesc LLVMAMDGPUUtils)


        


More information about the llvm-commits mailing list