[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

[Alan Phipps via Phabricator via llvm-commits]

alanphipps added inline comments.


================
Comment at: llvm/test/tools/llvm-profdata/mcdc-bitmap.test:1
+# Test MC/DC bitmap reading and merging.
+
----------------
ellis wrote:
> ellis wrote:
> > I just recently discovered `split-file` (https://llvm.org/docs/TestingGuide.html#extra-files). Since we only use the `.proftext` files in this test we can put their contents here so that everything is in one place. This will make this file much larger, so it's up to you if you think it's worth it.
> I've used `split-file` a few times since I made this comment and I think it should be used for this test, but let me know what you think
Apologies, not sure how, but I overlooked this comment! I agree using `split-file` would help this test. I wasn't aware of it -- I need to review these guides.  I'll make the change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138846/new/

https://reviews.llvm.org/D138846