[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

[Ellis Hoag via Phabricator via llvm-commits]

ellis added a comment.

All my comments (except my last one) seems to be resolved so looks good to me! After @paquette's latest comments are resolved I'll do a final pass



================
Comment at: llvm/test/tools/llvm-profdata/mcdc-bitmap.test:1
+# Test MC/DC bitmap reading and merging.
+
----------------
ellis wrote:
> I just recently discovered `split-file` (https://llvm.org/docs/TestingGuide.html#extra-files). Since we only use the `.proftext` files in this test we can put their contents here so that everything is in one place. This will make this file much larger, so it's up to you if you think it's worth it.
I've used `split-file` a few times since I made this comment and I think it should be used for this test, but let me know what you think


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138846/new/

https://reviews.llvm.org/D138846