[PATCH] D154066: [NFC][TableGen] Refactor the implementation of arguments
Philip Reames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 5 12:41:02 PDT 2023
reames added a comment.
Please collapse PositionalArgumentInit into ArgumentInit for this patch. As of this patch, there is no other kind, and the various dispatch logic is just confusing on it's own.
The main value of this patch, and the reason I suggested it, was the type signature change. Having ArgumentInit in place allows you to split it's subclasses in the next change, and focus the review on that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154066/new/
https://reviews.llvm.org/D154066
More information about the llvm-commits
mailing list