[llvm] 4e20ad9 - [X86] Remove unnecessary vzeroall/vzeroupper overrides from znver1/znver2 models
Simon Pilgrim via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 5 04:28:05 PDT 2023
Author: Simon Pilgrim
Date: 2023-07-05T12:27:42+01:00
New Revision: 4e20ad9470c27a4b4f3a5931c98264bfa014528d
URL: https://github.com/llvm/llvm-project/commit/4e20ad9470c27a4b4f3a5931c98264bfa014528d
DIFF: https://github.com/llvm/llvm-project/commit/4e20ad9470c27a4b4f3a5931c98264bfa014528d.diff
LOG: [X86] Remove unnecessary vzeroall/vzeroupper overrides from znver1/znver2 models
Noticed while trying to resurrect D138359 - the overrides matched the base class schedule WriteSystem/WriteMicrocoded definition (apart from znver2 where vzeroupper is almost free)
Added:
Modified:
llvm/lib/Target/X86/X86ScheduleZnver1.td
llvm/lib/Target/X86/X86ScheduleZnver2.td
Removed:
################################################################################
diff --git a/llvm/lib/Target/X86/X86ScheduleZnver1.td b/llvm/lib/Target/X86/X86ScheduleZnver1.td
index d5cce17de12b5f..0e001638d03d95 100644
--- a/llvm/lib/Target/X86/X86ScheduleZnver1.td
+++ b/llvm/lib/Target/X86/X86ScheduleZnver1.td
@@ -1315,14 +1315,6 @@ def : SchedAlias<WriteDPPD, ZnWriteMicrocoded>;
// x,m,i.
def : SchedAlias<WriteDPPDLd, ZnWriteMicrocoded>;
-//-- Other instructions --//
-
-// VZEROUPPER.
-def : InstRW<[WriteMicrocoded], (instrs VZEROUPPER)>;
-
-// VZEROALL.
-def : InstRW<[WriteMicrocoded], (instrs VZEROALL)>;
-
///////////////////////////////////////////////////////////////////////////////
// Dependency breaking instructions.
///////////////////////////////////////////////////////////////////////////////
diff --git a/llvm/lib/Target/X86/X86ScheduleZnver2.td b/llvm/lib/Target/X86/X86ScheduleZnver2.td
index b6c29eebeb79d6..117885406a0a34 100644
--- a/llvm/lib/Target/X86/X86ScheduleZnver2.td
+++ b/llvm/lib/Target/X86/X86ScheduleZnver2.td
@@ -1321,9 +1321,6 @@ def : SchedAlias<WriteDPPDLd, Zn2WriteMicrocoded>;
// VZEROUPPER.
def : InstRW<[WriteALU], (instrs VZEROUPPER)>;
-// VZEROALL.
-def : InstRW<[WriteMicrocoded], (instrs VZEROALL)>;
-
///////////////////////////////////////////////////////////////////////////////
// Dependency breaking instructions.
///////////////////////////////////////////////////////////////////////////////
More information about the llvm-commits
mailing list