[PATCH] D154363: [mlir] Add an interface to decompose complex ops
Quentin Colombet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 5 03:08:46 PDT 2023
qcolombet updated this revision to Diff 537279.
qcolombet retitled this revision from "[WIP][mlir] Add an interface to decompose complex ops" to "[mlir] Add an interface to decompose complex ops".
qcolombet added a comment.
- Make the AggregatedOpInterface specific to Linalg for now (we may want to drop the interface and just use rewriter patterns.)
- Fix nits: comments, function names, move the builder first in all the added functions
- Make the implementation of the transform op cleaner (i.e., support multi result in the returned value).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154363/new/
https://reviews.llvm.org/D154363
Files:
mlir/include/mlir/Dialect/Linalg/IR/LinalgInterfaces.td
mlir/include/mlir/Dialect/Linalg/IR/LinalgOps.td
mlir/include/mlir/Dialect/Linalg/TransformOps/LinalgTransformOps.td
mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
mlir/lib/Dialect/Linalg/TransformOps/LinalgTransformOps.cpp
mlir/test/Dialect/Linalg/transform-op-decompose.mlir
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154363.537279.patch
Type: text/x-patch
Size: 17980 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230705/79292ce1/attachment-0001.bin>
More information about the llvm-commits
mailing list