[PATCH] D154363: [WIP][mlir] Add an interface to decompose complex ops

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache added inline comments.


================
Comment at: mlir/include/mlir/Interfaces/AggregatedOpInterface.td:2
+//===- TilingInterface.td - Interface for tiling operations *- tablegen -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
----------------
jpienaar wrote:
> qcolombet wrote:
> > nicolasvasilache wrote:
> > > chelini wrote:
> > > > Why this interface is not part of Linalg? 
> > > +1 to moving the interface in Linalg, this is not a general concept AFAICT
> > I thought this could generally be useful.
> > E.g., we have some expand passes (`expand-strided-metadata`, `memref-expand`) right now that could fit in this interface. But yeah, let's leave that out.
> What is not a general concept here? This seems rather general and generally usable.
Fair enough, if there is value in reusing this interface by all means let's.
If this needs to mature more, Linalg can be a place to shepherd it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154363/new/

https://reviews.llvm.org/D154363