[PATCH] D154363: [WIP][mlir] Add an interface to decompose complex ops

Tue Jul 4 09:25:29 PDT 2023

qcolombet added inline comments.

================
Comment at: mlir/include/mlir/Interfaces/AggregatedOpInterface.td:21
+  let description = [{
+    Interface for decomposing aggregated operations into a sequence of simpler
+    ops.
----------------
qcolombet wrote:
> qcolombet wrote:
> > jpienaar wrote:
> > > This seems rather abstract. This seems like querying a rewrite set to see if root pattern matcher exists that matches an op, except the rewrite set is coupled with the op rather than generic. Is that what this is?
> > Yes, that's exactly that.
> @jpienaar 
> Do you think it would make sense for this interface to return a pattern instead?
Btw maybe a pass with greedy pattern rewriter is fine. I only reproduced what iree was doing here.

What do you all think?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154363/new/

https://reviews.llvm.org/D154363