[PATCH] D154424: [AMDGPU] Add functions for composing and decomposing S_WAIT_DEPCTR operands

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 4 02:58:40 PDT 2023


foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp:1173
            (MI.getOpcode() == AMDGPU::S_WAITCNT_DEPCTR &&
-            MI.getOperand(0).getImm() == 0xffe3);
+            AMDGPU::DepCtr::decodeFieldVmVsrc(MI.getOperand(0).getImm()) == 0);
   };
----------------
Strictly speaking changes like this one are not NFC, since the new code ignores the non-VmVsrc bits of the immediate value, but that seems like an obvious improvement.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154424/new/

https://reviews.llvm.org/D154424



More information about the llvm-commits mailing list