[PATCH] D154424: [AMDGPU] Add functions for composing and decomposing S_WAIT_DEPCTR operands

[Stephen Thomas via Phabricator via llvm-commits]

stepthomas added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp:1297
+        AMDGPU::DepCtr::encodeFieldSaSdst(MI.getOperand(0).getImm(), 0) ==
+            0xfffe)
       return true;
----------------
This is wrong. it should be a simple test that sa_sdst is zero, not a test that everything that isn't sa_sdst is set while sa_sdst isn't cared about. Fixing this requires a lit test to be updated, however, so I'll make that a separate patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154424/new/

https://reviews.llvm.org/D154424