[PATCH] D154355: [ARM] make execute only long call test checks more robust
Oliver Stannard via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 4 01:46:57 PDT 2023
olista01 accepted this revision.
olista01 added a comment.
This revision is now accepted and ready to land.
One comment which would improve the robustness a bit more, other than that LGTM.
================
Comment at: llvm/test/CodeGen/Thumb/thumb-execute-only-long-calls.ll:6
; CHECK-LABEL: fn:
-; CHECK: ldr [[REG:r[0-9]+]], .LCPI0_0
+; CHECK: ldr [[REG:r[0-9]+]], [[LABEL:[^\s]+]]0_0
; CHECK-NEXT: blx [[REG]]
----------------
I'd suggest removing the "0_0" here (and on line 8) so that it gets included by the regex, and the test won't fail if the label numbering changes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154355/new/
https://reviews.llvm.org/D154355
More information about the llvm-commits
mailing list