[PATCH] D154355: [ARM] make execute only long call test checks more robust

Ties Stuij via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 3 10:04:06 PDT 2023


stuij updated this revision to Diff 536813.
stuij marked an inline comment as done.
stuij added a comment.

address review comments


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154355/new/

https://reviews.llvm.org/D154355

Files:
  llvm/test/CodeGen/Thumb/thumb-execute-only-long-calls.ll


Index: llvm/test/CodeGen/Thumb/thumb-execute-only-long-calls.ll
===================================================================
--- llvm/test/CodeGen/Thumb/thumb-execute-only-long-calls.ll
+++ llvm/test/CodeGen/Thumb/thumb-execute-only-long-calls.ll
@@ -1,11 +1,11 @@
-; RUN: llc < %s -mtriple=thumbv6m-arm-none-eabi -relocation-model=static | FileCheck %s -check-prefixes=CHECK
+; RUN: llc < %s -mtriple=thumbv6m-none-eabi -relocation-model=static | FileCheck %s -check-prefixes=CHECK
 
 define void @fn() #0 {
 entry:
 ; CHECK-LABEL: fn:
-; CHECK:       ldr [[REG:r[0-9]+]], .LCPI0_0
+; CHECK:       ldr [[REG:r[0-9]+]], [[LABEL:[^\s]+]]0_0
 ; CHECK-NEXT:  blx [[REG]]
-; CHECK:       .LCPI0_0:
+; CHECK:       [[LABEL]]0_0:
 ; CHECK-NEXT:  .long   bar
   call void @bar()
   ret void
@@ -14,14 +14,14 @@
 define void @execute_only_fn() #1 {
 ; CHECK-LABEL: execute_only_fn:
 ; CHECK:       movs    [[REG0:r[0-9]+]], :upper8_15:bar
-; CHECK-NEXT:  lsls    [[REG0]], r0, #8
+; CHECK-NEXT:  lsls    [[REG0]], [[REG0]], #8
 ; CHECK-NEXT:  adds    [[REG0]], :upper0_7:bar
-; CHECK-NEXT:  lsls    [[REG0]], r0, #8
+; CHECK-NEXT:  lsls    [[REG0]], [[REG0]], #8
 ; CHECK-NEXT:  adds    [[REG0]], :lower8_15:bar
-; CHECK-NEXT:  lsls    [[REG0]], r0, #8
+; CHECK-NEXT:  lsls    [[REG0]], [[REG0]], #8
 ; CHECK-NEXT:  adds    [[REG0]], :lower0_7:bar
 ; CHECK-NEXT:  blx     [[REG0]]
-; CHECK-NOT:   .LCPI1_0:
+; CHECK-NOT:   ldr
 
 entry:
   call void @bar()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154355.536813.patch
Type: text/x-patch
Size: 1456 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230703/b8be17b7/attachment.bin>


More information about the llvm-commits mailing list