[PATCH] D154233: [ARM] generate correct code for armv6-m XO big stack operations

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMAsmPrinter.cpp:1360
+        Offset = MI->getOperand(3).getImm();
+        AFI->EHPrologueOffsetInRegs[DstReg] |= Offset;
+        break;
----------------
stuij wrote:
> efriedma wrote:
> > `+=`?
> yea, I went back and forth on this! Using addition which is analogous but won't represent what the processor will actually do felt more wrong than expressing what we expect it to do. But really I'm fine either way. Changed it.
My primary concern with my review comments is making sure if someone messes with tMOVi32imm expansion, this code with either continue to work correctly, or assert that it's seeing something unexpected.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154233/new/

https://reviews.llvm.org/D154233