[PATCH] D154233: [ARM] generate correct code for armv6-m XO big stack operations

Ties Stuij via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 3 10:42:03 PDT 2023


stuij marked an inline comment as done.
stuij added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMAsmPrinter.cpp:1360
+        Offset = MI->getOperand(3).getImm();
+        AFI->EHPrologueOffsetInRegs[DstReg] |= Offset;
+        break;
----------------
efriedma wrote:
> `+=`?
yea, I went back and forth on this! Using addition which is analogous but won't represent what the processor will actually do felt more wrong than expressing what we expect it to do. But really I'm fine either way. Changed it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154233/new/

https://reviews.llvm.org/D154233



More information about the llvm-commits mailing list