[PATCH] D153950: Reset NoPHI MachineFunction property in X86CmovConversion

Orlando Cazalet-Hyams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 02:40:10 PDT 2023


This revision was automatically updated to reflect the committed changes.
Closed by commit rG03adc5f16fdd: Reset NoPHI MachineFunction property in X86CmovConversion (authored by Orlando).

Changed prior to commit:
  https://reviews.llvm.org/D153950?vs=535275&id=535299#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153950/new/

https://reviews.llvm.org/D153950

Files:
  llvm/lib/Target/X86/X86CmovConversion.cpp


Index: llvm/lib/Target/X86/X86CmovConversion.cpp
===================================================================
--- llvm/lib/Target/X86/X86CmovConversion.cpp
+++ llvm/lib/Target/X86/X86CmovConversion.cpp
@@ -862,6 +862,11 @@
     RegRewriteTable[DestReg] = std::make_pair(Op1Reg, Op2Reg);
   }
 
+  // Reset the NoPHIs property if a PHI was inserted to prevent a conflict with
+  // the MachineVerifier during testing.
+  if (MIItBegin != MIItEnd)
+    F->getProperties().reset(MachineFunctionProperties::Property::NoPHIs);
+
   // Now remove the CMOV(s).
   MBB->erase(MIItBegin, MIItEnd);
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153950.535299.patch
Type: text/x-patch
Size: 598 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230628/4255ab61/attachment.bin>


More information about the llvm-commits mailing list