[PATCH] D153950: Reset NoPHI MachineFunction property in X86CmovConversion

Stephen Tozer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 01:58:07 PDT 2023


StephenTozer accepted this revision.
StephenTozer added a comment.
This revision is now accepted and ready to land.

The pass inserts a PHI, so needs to reset the `NoPHIs` property - makes sense. The property reset could be taken out of the loop and put undef a conditional `if (MIItBegin != MIItEnd)` - I'd leave that as optional though, because I imagine it makes very little difference in practice.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153950/new/

https://reviews.llvm.org/D153950



More information about the llvm-commits mailing list