[PATCH] D153950: Reset NoPHI MachineFunction property in X86CmovConversion
Orlando Cazalet-Hyams via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 28 02:41:38 PDT 2023
Orlando added a comment.
In D153950#4455311 <https://reviews.llvm.org/D153950#4455311>, @StephenTozer wrote:
> The pass inserts a PHI, so needs to reset the `NoPHIs` property - makes sense. The property reset could be taken out of the loop and put under a conditional `if (MIItBegin != MIItEnd)` - I'd leave that as optional though, because I imagine it makes very little difference in practice.
SGTM - done, thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153950/new/
https://reviews.llvm.org/D153950
More information about the llvm-commits
mailing list