[PATCH] D153204: RISCVAsmParser: support comments in more places

[Abel Bernabeu via Phabricator via llvm-commits]

abel-bernabeu added a comment.

1. Use "LI" rather than "VSETIVLI". It really does not matter what instruction you use for testing the handling of comments. Think of those backporting the patch to very old versions of LLVM.

2. Make an independent file for this test. When the test fails because of the handling of comments the test name would point very straight to the issue.

3. Check that the comments are placed into the assembler rather than ignored.

We spent a bit of time on the review of the original patch proposal for figuring out those things already. Cherry-pick my test at least :-D

https://reviews.llvm.org/D153008


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153204/new/

https://reviews.llvm.org/D153204