[PATCH] D149759: [symbolizer] Support symbol lookup

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin added a comment.

I believe it would be much better not to add the new mode (`SYMBOL`), but to support the new way of specifying an address for `CODE`.

Please, don't forget to reflected the changes in `llvm/docs/CommandGuide/llvm-symbolizer.rst` and probably `llvm/docs/CommandGuide/llvm-addr2line.rst`.



================
Comment at: llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp:227-229
+  // Address specification is a symbol if addr2line compatibility mode in on.
+  // Otherwise treat it as an error for compatibility with previous versions of
+  // llvm-symbolizer.
----------------
I don't think we need a new point of divergence here. It's unlikely that anyone would rely on the tool to generate an error for such an input.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149759/new/

https://reviews.llvm.org/D149759