[PATCH] D153180: [docs][TableGen][Target] Improve the documentation of the attribute value for SubtargetFeature.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 16 19:10:39 PDT 2023


arsenm added a comment.

This sounds better behaved than



================
Comment at: llvm/docs/WritingAnLLVMBackend.rst:1772
+of an enum constant. If multiple features use the same integer attribute, the
+attribute will be set to the maximum value of all enabled features that share
+the attribute.
----------------
Is this really true? Where is this implemented?


================
Comment at: llvm/docs/WritingAnLLVMBackend.rst:1773
+attribute will be set to the maximum value of all enabled features that share
+the attribute.
+
----------------
Don't refer to it as an attribute, attributes are a separate thing entirely


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153180/new/

https://reviews.llvm.org/D153180



More information about the llvm-commits mailing list