[PATCH] D153180: [docs][TableGen][Target] Improve the documentation of the attribute value for SubtargetFeature.

[Paul Kirth via Phabricator via llvm-commits]

paulkirth added a comment.

Thanks so much for adding this! This is definitely LGTM from me, but I'll let your other reviewers decide if anything else should be added.



================
Comment at: llvm/docs/WritingAnLLVMBackend.rst:1768
 
+If the value for the attribute is the string "true" or "false", the attribute
+is assumed to be a bool and only one SubtargetFeature should refer to it.
----------------
Do you think it would help to reference which parameter you're referring to in the example code?

Also, do you think it bears mentioning how the boolean value is determined? It is certainly an implementation detail, but it may be good to specify.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153180/new/

https://reviews.llvm.org/D153180