[PATCH] D153162: [dsymutil] Fix .debug_addr index calculation

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 16 13:20:51 PDT 2023


JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.


================
Comment at: llvm/tools/dsymutil/DwarfLinkerForBinary.cpp:1093
+        return RelocAdjustment;
+      return std::nullopt;
     }
----------------
avl wrote:
> probably, just
> 
> 
> ```
> return hasValidRelocationAt(ValidDebugAddrRelocs, StartOffset, EndOffset);
> ```
> 
> ?
Yup, thanks, I meant to unstage that part. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153162/new/

https://reviews.llvm.org/D153162



More information about the llvm-commits mailing list