[PATCH] D153162: [dsymutil] Fix .debug_addr index calculation

Alexey Lapshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 16 13:13:55 PDT 2023


avl accepted this revision.
avl added a comment.
This revision is now accepted and ready to land.

LGTM, with addressing small code simplification suggestion.



================
Comment at: llvm/tools/dsymutil/DwarfLinkerForBinary.cpp:1093
+        return RelocAdjustment;
+      return std::nullopt;
     }
----------------
probably, just


```
return hasValidRelocationAt(ValidDebugAddrRelocs, StartOffset, EndOffset);
```

?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153162/new/

https://reviews.llvm.org/D153162



More information about the llvm-commits mailing list