[PATCH] D153034: [PowerPC][Future] Enable __builtin_mma_xxm[t|f]acc on future isa

[Stefan Pintilie via Phabricator via llvm-commits]

stefanp added a comment.

The SelectionDAG object may have an easier way for you do to what you are trying to do here. I've added a comment. If you use the selection DAG my nit will probably just disappear.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:10729
+    SDNode *OpNode = Op.getNode();
+    for (SDNode *Use : OpNode->uses()) {
+      SmallVector<SDValue, 4> NewOps;
----------------
There is an easier way to do this. 
Take a look at:
```
DAG.ReplaceAllUsesWith(From, To);
```


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:10732
+      for (SDValue UseOp : Use->ops()) {
+        // pointer comparison to make sure we are replacing the correct operand
+        if (UseOp.getNode() == OpNode)
----------------
nit:
Full sentence for comment please. :) 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153034/new/

https://reviews.llvm.org/D153034